[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

2022-03-05 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28bb040ded83: [clang-format] QualifierOrder does not reorder template arguments (authored by MyDeveloperDay). Changed prior to commit: https://rev

[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

2022-03-02 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Herald added a project: All. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:910 + Style); + verifyFormat("TemplateType t;", "TemplateType t;", Style); +} HazardyKnusperkeks wrote: > As far as I understand

[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

2022-03-01 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:480-482 +if (Tok->TokenText.size() == 1) + return false; return true; Maybe? Comment at:

[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

2022-03-01 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:344-346 + // If the template closer is closing the requires clause + // t

[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

2022-03-01 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/53981 Reorder the qualifiers inside the template ar