[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f5bdaf481c3: [Driver] Split up huge aarch64-cpus.c test. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn updated this revision to Diff 412971. fhahn added a comment. Thanks everyone! I added a TODO for splitting up by category and plan to land this soon. The update also adds a missing GENERIC check line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. OK Cool. Lets not punish Florian for improving things. If anyone want to go and split this file sensibly, that sounds good. In the meantime this LGTM. Repository: rG LLVM Github Monorepo

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn added a comment. In D120875#3356432 , @simon_tatham wrote: >> While splitting up the test file is not ideal [...] > > Actually I'm not so sure. I'd almost rather go further, and split it up into > lots of //much// smaller files, each with some

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

simon_tatham added a comment. > While splitting up the test file is not ideal [...] Actually I'm not so sure. I'd almost rather go further, and split it up into lots of //much// smaller files, each with some kind of reasonable theme, like "all the basically v8.1-A stuff" or "all the v8M". The

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

tyb0807 added a comment. Thanks for making this change. However, I think a better split would be - List Item `aarch64-cpus.c` which contains cpu-specific test cases (usually with `-mcpu` flag). Roughly this is until line 515, plus some last test cases from line 926 to end. `aarch64-archs.c`

[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.

fhahn created this revision. fhahn added reviewers: simon_tatham, dmgreen, tmatheson, tyb0807. Herald added a subscriber: kristof.beyls. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. This test file has grown to the point where it takes a huge