[PATCH] D121063: [AST] Make the last element in the linked list null

2022-03-07 Thread Bill Wendling via Phabricator via cfe-commits
void abandoned this revision. void added a comment. In D121063#3364872 , @erichkeane wrote: > In D121063#3364833 , @void wrote: > >> In D121063#3364815 , @erichkeane >>

[PATCH] D121063: [AST] Make the last element in the linked list null

2022-03-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D121063#3364833 , @void wrote: > In D121063#3364815 , @erichkeane > wrote: > >> In D121063#3364810 , @void wrote: >> >>> In D121063#3364780

[PATCH] D121063: [AST] Make the last element in the linked list null

2022-03-07 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. In D121063#3364815 , @erichkeane wrote: > In D121063#3364810 , @void wrote: > >> In D121063#3364780 , @void wrote: >> >>> In D121063#3363852

[PATCH] D121063: [AST] Make the last element in the linked list null

2022-03-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D121063#3364810 , @void wrote: > In D121063#3364780 , @void wrote: > >> In D121063#3363852 , @erichkeane >> wrote: >> >>> I suspect this wo

[PATCH] D121063: [AST] Make the last element in the linked list null

2022-03-07 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. In D121063#3364780 , @void wrote: > In D121063#3363852 , @erichkeane > wrote: > >> I suspect this works because we never really treated this as a LL, just as a >> pair of iterators. Two th

[PATCH] D121063: [AST] Make the last element in the linked list null

2022-03-07 Thread Bill Wendling via Phabricator via cfe-commits
void added a subscriber: urnathan. void added a comment. In D121063#3363852 , @erichkeane wrote: > I suspect this works because we never really treated this as a LL, just as a > pair of iterators. Two things: > > 1- Can you produce some situation where

[PATCH] D121063: [AST] Make the last element in the linked list null

2022-03-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I suspect this works because we never really treated this as a LL, just as a pair of iterators. Two things: 1- Can you produce some situation where this is valuable to do? 2- Can you switch this over so that the NextInContextAndBits initializes to nullptr/0 so that

[PATCH] D121063: [AST] Make the last element in the linked list null

2022-03-07 Thread Nathan Sidwell via Phabricator via cfe-commits
urnathan resigned from this revision. urnathan added a comment. Huh? this web interface is confusing. How did this ever work -- doesn't the decl's ctor set this to null? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121063/new/ https://reviews.ll

[PATCH] D121063: [AST] Make the last element in the linked list null

2022-03-05 Thread Bill Wendling via Phabricator via cfe-commits
void created this revision. void added reviewers: erichkeane, aaron.ballman, urnathan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last element in a linked list should point to null, so that we can