[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains updated this revision to Diff 413612. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 Files: clang/lib/Frontend/FrontendAction.cpp clang/lib/Sema/SemaModule.cpp

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains updated this revision to Diff 414891. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 Files: clang/lib/Frontend/FrontendAction.cpp clang/lib/Sema/SemaModule.cpp

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

ChuanqiXu added a comment. It lacks tests. This is not NFC, right? --- I am a little bit confused for the intuition. Couldn't we just import the pre-processed header? What's the problem? Could you elaborate on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains added a comment. In D121098#3378375 , @ChuanqiXu wrote: > It lacks tests. This is not NFC, right? Right, (there are tests with the next patch which introduces the mechanism for producing the pre-processed output) but, I will find a suitable one f

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

ChuanqiXu added a comment. In D121098#3383835 , @iains wrote: >> I am a little bit confused for the intuition. Couldn't we just import the >> pre-processed header? What's the problem? Could you elaborate on this? > > We cannot import a pre-processed file

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains added a comment. In D121098#3384590 , @ChuanqiXu wrote: > In D121098#3383835 , @iains wrote: > >>> I am a little bit confused for the intuition. Couldn't we just import the >>> pre-processed header? What's

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

ChuanqiXu added a comment. OK, I feel good if this one contains tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 ___ cfe-commits mailing list cfe-commits@

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains updated this revision to Diff 416847. iains added a comment. rebased, added test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 Files: clang/lib/Frontend/FrontendAction.cpp clang/lib/Sema/Sema

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

urnathan added a comment. yeah, gcc's preprocessor has peeking code to deal with this (more generally than modules) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 ___

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains updated this revision to Diff 418082. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ https://reviews.llvm.org/D121098 Files: clang/lib/Frontend/FrontendAction.cpp clang/lib/Sema/SemaModule.cpp

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9cea8d3a8ff: [C++20][Modules][HU 4/5] Handle pre-processed header units. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121098/new/ htt

[PATCH] D121098: [C++20][Modules][HU 4/5] Handle pre-processed header units.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. We wish to support emitting a pre-processed output for an importable header