[PATCH] D121306: [Sema] add warning for tautological FP compare with literal

2022-03-24 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. In D121306#3405824 , @alexfh wrote: > What's the right fix for this warning, using a literal of the same floating > point type? Probably? Depends on why you're trying to use equality on floating-point numbers; "x == 0.3" is in

[PATCH] D121306: [Sema] add warning for tautological FP compare with literal

2022-03-24 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. What's the right fix for this warning, using a literal of the same floating point type? Did you consider adding a fixit hint to the diagnostic? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121306/new/ https://reviews.llvm.

[PATCH] D121306: [Sema] add warning for tautological FP compare with literal

2022-03-17 Thread Sanjay Patel via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGab982eace6e4: [Sema] add warning for tautological FP compare with literal (authored by spatel). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo