[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

MaskRay added a comment. FWIW I interpreted dexonsmith's resign from the patch as his ambivalence or minor objection to the direction, otherwise I'd expect a LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

MaskRay added a comment. In D121560#3448733 , @abrachet wrote: > In D121560#3439570 , @MaskRay wrote: > >> If you need a -static-libstdc++ not subject to unused argument warning, >> --start-no-unused-arguments

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet added a comment. In D121560#3439570 , @MaskRay wrote: > If you need a -static-libstdc++ not subject to unused argument warning, > --start-no-unused-arguments and D53238 > (-static=c++stdlib) may be better

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

MaskRay added a comment. If you need a -static-libstdc++ not subject to unused argument warning, D53238 -static=c++stdlib may be a better choice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet updated this revision to Diff 420375. abrachet added a comment. Actually clang-format... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files: clang-tools-extra/clangd/CompileCommands.cpp clang/include/clang/Driver/Options.h

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet updated this revision to Diff 419491. abrachet added a comment. Rebase so patch applies CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files: clang-tools-extra/clangd/CompileCommands.cpp clang/include/clang/Driver/Options.h

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet updated this revision to Diff 417313. abrachet marked an inline comment as done. abrachet added a comment. Herald added subscribers: pmatos, asb, StephenFan. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files:

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet marked an inline comment as done. abrachet added a comment. In D121560#3378181 , @MaskRay wrote: >> This patch adds an example for -static-libcxx and -nostdlib. > > We have -static-libstdc++ but not -static-libc++. (D53238 >

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet updated this revision to Diff 414965. abrachet edited the summary of this revision. abrachet added a comment. Update example to have multiple options in NoArgUnusedWith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121560/new/ https://reviews.llvm.org/D121560 Files:

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

MaskRay added a comment. > This patch adds an example for -static-libcxx and -nostdlib. We have -static-libstdc++ but not -static-libc++. (D53238 attempts to add `-static` and name it `-static=c++stdlib`) > NoArgUnusedWith can be used for options which

[PATCH] D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options

abrachet created this revision. abrachet added reviewers: MaskRay, thakis. Herald added subscribers: ormris, dang, usaxena95, kadircet, rupprecht, arphaman, steven_wu, hiraditya, arichardson, sbc100, emaste. Herald added a reviewer: JDevlieghere. Herald added a reviewer: alexander-shaposhnikov.