[PATCH] D121678: [pseudo] Split greatergreater token.

hokein added a comment. Thanks for the report and revert, and sorry for the failures and the late response (was OOO on Friday). > One of our guys speculates that because some allocations are "owned" by the > returned TokenStream, but the returned TokenStream is a temporary, the > lifetimes

[PATCH] D121678: [pseudo] Split greatergreater token.

probinson added a comment. We had the same thing happen downstream. One of our guys speculates that because some allocations are "owned" by the returned TokenStream, but the returned TokenStream is a temporary, the lifetimes might not be sufficient and some deallocations can happen. If I

[PATCH] D121678: [pseudo] Split greatergreater token.

zequanwu added a comment. This fails on windows bot at https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8819402935494502225/+/u/package_clang/stdout?format=raw. C:\b\s\w\ir\cache\builder\src\third_party\llvm\clang-tools-extra\pseudo\unittests\TokenTest.cpp(190): error:

[PATCH] D121678: [pseudo] Split greatergreater token.

uabelho added a comment. Hello, It seems like the new testcase fails when run with sanitizers: https://lab.llvm.org/buildbot/#/builders/5/builds/20833 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121678/new/ https://reviews.llvm.org/D121678

[PATCH] D121678: [pseudo] Split greatergreater token.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf66d3758bda9: [pseudo] Split greatergreater token. (authored by hokein). Changed prior to commit:

[PATCH] D121678: [pseudo] Split greatergreater token.

hokein updated this revision to Diff 416153. hokein added a comment. Herald added a project: clang-tools-extra. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121678/new/ https://reviews.llvm.org/D121678 Files:

[PATCH] D121678: [pseudo] Split greatergreater token.

hokein updated this revision to Diff 415387. hokein marked 4 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121678/new/ https://reviews.llvm.org/D121678 Files:

[PATCH] D121678: [pseudo] Split greatergreater token.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This seems like the right approach to me. It seems a bit strange to be doing this whether we're parsing C++ or not, but I guess we're not going to want low-level grammar differences

[PATCH] D121678: [pseudo] Split greatergreater token.

hokein updated this revision to Diff 415377. hokein added a comment. define a greatergreater nonterminal per discussion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121678/new/ https://reviews.llvm.org/D121678 Files:

[PATCH] D121678: [pseudo] Split greatergreater token.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang. For a >> token (a right shift operator, or a nested template?), the clang lexer always