[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG43c146c96d8e: [clang-format] Take out common code for parsing blocks NFC (authored by sstwcw). Changed prior to commit: https://reviews.llvm.org/D121757?vs=420653&id=426277#toc Repository: rG LLVM Gi

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw added a comment. Would you have a look at the parent revision namely D121756 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 ___

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 _

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw updated this revision to Diff 420653. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/lib/Format/UnwrappedLineParser.h Index: clang/lib/For

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw updated this revision to Diff 420652. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121757/new/ https://reviews.llvm.org/D121757 Files: clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/UnwrappedLinePar

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

owenpan added a comment. In D121757#3415402 , @sstwcw wrote: > I ran check-clang after formatting the entire code base with the new version. > It turned out it did break some tests. It seems to be because it messed up > these comments. > > diff --gi

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw added a comment. I ran check-clang after formatting the entire code base with the new version. It turned out it did break some tests. It seems to be because it messed up these comments. diff --git a/clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.fallthrough/p1.cpp b/clang/test/CXX/dcl.dcl

[PATCH] D121757: [clang-format] Take out common code for parsing blocks NFC

sstwcw updated this revision to Diff 419009. sstwcw retitled this revision from "[clang-format] Take out common code for parsing blocks" to "[clang-format] Take out common code for parsing blocks NFC". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12