This revision was automatically updated to reflect the committed changes.
Closed by commit rGce21c926f8ef: [Clang] Work with multiple pragmas weak before
definition (authored by hubert.reinterpretcast).
Changed prior to commit:
https://reviews.llvm.org/D121927?vs=417755&id=418092#toc
Repositor
hubert.reinterpretcast updated this revision to Diff 417755.
hubert.reinterpretcast added a comment.
- Adjust per observation: Use DenseMapInfo for the alias pointer value
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121927/new/
https://reviews.ll
aaron.ballman added inline comments.
Comment at: clang/include/clang/Sema/Weak.h:47
+static unsigned getHashValue(const WeakInfo &W) {
+ return W.getAlias() ? DenseMapInfo::getHashValue(W.getAlias()->getName())
+ : DenseMapInfo::getHashValue("");
hubert.reinterpretcast added inline comments.
Comment at: clang/include/clang/Sema/Weak.h:47
+static unsigned getHashValue(const WeakInfo &W) {
+ return W.getAlias() ? DenseMapInfo::getHashValue(W.getAlias()->getName())
+ : DenseMapInfo::getHashV
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, thank you for the fix!
Comment at: clang/include/clang/Sema/Weak.h:62
+return false;
+ return LHS.getAlias()->getName() == RHS.getAlias()->getName();
+}
hubert.reinterpr
hubert.reinterpretcast added a comment.
@aaron.ballman, I believe I have responded to all of the comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121927/new/
https://reviews.llvm.org/D121927
___
c
hubert.reinterpretcast updated this revision to Diff 417666.
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added a comment.
- Address review comments: Return `const` from getAlias()
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
hubert.reinterpretcast updated this revision to Diff 417443.
hubert.reinterpretcast added a comment.
- Address review comments: Add release notes, expand comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121927/new/
https://reviews.llvm.org/D1
hubert.reinterpretcast added inline comments.
Comment at: clang/include/clang/Sema/Weak.h:33
+ : alias(Alias), loc(Loc) {}
+ inline IdentifierInfo *getAlias() const { return alias; }
inline SourceLocation getLocation() const { return loc; }
hubert.reinte
hubert.reinterpretcast updated this revision to Diff 417386.
hubert.reinterpretcast marked 2 inline comments as done.
hubert.reinterpretcast added a comment.
- Address review comments: Use default member init in WeakInfo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.
Comment at: clang/include/clang/Sema/Weak.h:33
+ : alias(Alias), loc(Loc) {}
+ inline IdentifierInfo *getAlias() const { return alias; }
inline SourceLocation getLocati
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.
Comment at: clang/include/clang/Sema/Weak.h:62
+return false;
+ return LHS.getAlias()->getName() == RHS.getAlias()->getName();
+}
aaron.ballman
aaron.ballman added a comment.
Can you also add a release note for the fix?
Comment at: clang/include/clang/Sema/Sema.h:1075-1077
/// WeakUndeclaredIdentifiers - Identifiers contained in
/// \#pragma weak before declared. rare. may alias another
/// identifier, declare
hubert.reinterpretcast updated this revision to Diff 417042.
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added a comment.
- Address review comments: Remove deleted non-operator member functions; add
extra line to test
Repository:
rG LLVM Github Monorepo
CH
hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.
Comment at: clang/include/clang/Sema/Weak.h:35
inline SourceLocation getLocation() const { return loc; }
- void setUsed(bool Used=true) { used = Used; }
- inline bool getUs
cebowleratibm accepted this revision.
cebowleratibm added a comment.
This revision is now accepted and ready to land.
Makes sense to me.
Comment at: clang/include/clang/Sema/Weak.h:35
inline SourceLocation getLocation() const { return loc; }
- void setUsed(bool Used=true) {
hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: jamieschmeiser, aaron.ballman,
chandlerc, cebowleratibm, w2yehia.
Herald added a project: All.
hubert.reinterpretcast requested review of this revision.
Herald added a project: clang.
Update `WeakUndeclaredIdent
17 matches
Mail list logo