[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added a comment. In D121951#3393928 , @sameerds wrote: > In D121951#3392470 , @scott.linder > wrote: > >> In D121951#3391472 , @sameerds >> wrote: >> >>> Th

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

sameerds added a comment. In D121951#3392470 , @scott.linder wrote: > In D121951#3391472 , @sameerds > wrote: > >> The check for "__ockl_hostcall_internal" is not longer relevant with the new >> hostcall attrib

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

sameerds added a comment. Yeah, it happened in D119216 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121951/new/ https://reviews.llvm.org/D121951 ___ cfe-commits mailin

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added a comment. In D121951#3391472 , @sameerds wrote: > The check for "__ockl_hostcall_internal" is not longer relevant with the new > hostcall attribute. Can we simply remove this check? What is the situation > where the warning is still

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

sameerds added a comment. The check for "__ockl_hostcall_internal" is not longer relevant with the new hostcall attribute. Can we simply remove this check? What is the situation where the warning is still useful? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. A spurious warning still isn't ideal but this is an improvement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121951/new/ https://reviews.llvm.o

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:567 - if (auto HostcallFunction = M.getFunction("__ockl_hostcall_internal")) { + if (auto *HostcallFunction = M.getFunction("__ockl_hostcall_internal")) { for (auto &U :

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder added reviewers: sameerds, arsenm, rampitec, b-sumner, kzhuravl, yaxunl. scott.linder added a comment. For reference, the error I'm changing to a warning was added as part of https://reviews.llvm.org/D70038, and the issue that made me consider this approach appears when building OC

[PATCH] D121951: [AMDGPU] Only warn when mixing printf and hostcall

scott.linder created this revision. Herald added subscribers: foad, kerbowa, hiraditya, t-tye, Anastasia, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm. Herald added a project: All. scott.linder requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, w