[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG72acd042bad3: Pass split-machine-functions to code generator when flto is used (authored by junfd, committed by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 417458. junfd added a comment. Apply clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

wenlei added a comment. The linter warning seems legit, otherwise looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 ___ cfe-commits mailing list

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

hoy accepted this revision. hoy added a comment. This revision is now accepted and ready to land. lgtm, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 417387. junfd added a comment. Check the mixing -fsplit-machine-functions and -fno-split-machine-functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files:

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

hoy added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:577 + if (Args.hasArg(options::OPT_fsplit_machine_functions)) { +CmdArgs.push_back("-plugin-opt=-split-machine-functions"); Should also check

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 417146. junfd added a comment. Refine the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

wenlei added inline comments. Comment at: clang/test/Driver/split-machine-functions.c:2 +// Split machine functions only work for ELF, so disable the test on Windows +// UNSUPPORTED: system-windows + My understanding is that if you specify target, e.g. `-target

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 416555. junfd added a comment. Disable test on Windows, because -fsplit-machine-functions only works for ELF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files:

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd updated this revision to Diff 416363. junfd added a comment. Follow clang format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121969/new/ https://reviews.llvm.org/D121969 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

junfd created this revision. Herald added a subscriber: inglorion. Herald added a project: All. junfd requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121969 Files: