[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

hubert.reinterpretcast added a comment. In D121992#3418443 , @MaskRay wrote: > If you intend to overlay ld.so, you'll necessarily overlay libc, then > --sysroot seems just unneeded at all. Why? The header and library search paths are not restricted to

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf added a comment. In D121992#3418443 , @MaskRay wrote: > To add more why I think the current semantics may need more discussion before > we quickly commit to such a driver option: > > - interaction with --dyld-prefix: --sysroot does not affect the

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

MaskRay added a comment. To add more why I think the current semantics may need more discussion before we quickly commit to such a driver option: - interaction with --dyld-prefix: --sysroot does not affect the fallback --dyld-prefix. It seems even less appropriate for

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

MaskRay added a comment. In D121992#3407220 , @qiucf wrote: > Hi, > >> Why is --overlay-platform-toolchain added instead of using -isystem and -L? >> >> The functionality overlaps with -B. Unsure why introduce a new mechanism. > > We may want to use an

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf added a comment. Hi, > Why is --overlay-platform-toolchain added instead of using -isystem and -L? > > The functionality overlaps with -B. Unsure why introduce a new mechanism. We may want to use an extra toolchain like the Advance Toolchain

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

MaskRay added a comment. Why is --overlay-platform-toolchain added instead of using `-isystem` and `-L`? > In some cases, we need to set alternative toolchain path other than the > default with system (headers, libraries, dynamic linker prefix, ld path, > etc.), e.g., to pick up newer

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

This revision was automatically updated to reflect the committed changes. Closed by commit rGd00e8400e2e3: [Clang] Add option to set alternative toolchain path (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

hubert.reinterpretcast added a comment. LGTM; thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/ https://reviews.llvm.org/D121992 ___ cfe-commits mailing list

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf updated this revision to Diff 417566. qiucf marked 3 inline comments as done. qiucf added a comment. - Move test to another file - Add documentation on option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Driver/Driver.h:152 + /// Alternative toolchain path in prior to sysroot. + std::string OverlayToolChainPath; I don't understand the use of "in" in the comment. Perhaps "used" was

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf created this revision. qiucf added reviewers: hubert.reinterpretcast, jsji, nemanjai, collinbaker, rpenacob. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In some cases, we need to set