avogelsgesang added a comment.
@adamcz
> Ideally I'd like to see this code action show up as code completion option as
> well.
I think in the long-term such a "Implement methods" code action should also
apply as a quickfix for
class Base {
virtual void foo() = 0;
};
class Derive
avogelsgesang added a comment.
Thank for your comments, @adamcz and @njames93!
I agree that a "Implement interface" tweak is probably more useful, and I can
imagine to evolve this tweak in that direction.
The main reason, I first went for the "create a new class from scratch"
approach, was bec
njames93 added a comment.
In its current incarnation, I struggle to see the use case for this.
Most of the time Base classes live in header files are pretty much every time
this tweak is applied you will then want to move the class.
The idea about just implementing the interface I had started in
adamcz added a comment.
Thanks, this looks really good! I always wanted a code action like this.
I always envisioned this as a code action on a class to implement missing
virtual methods though. The idea would be:
class Foo : public B^ar { };
expands into:
class Foo : public Bar {
int baz
avogelsgesang added reviewers: sammccall, nridge, njames93, hokein.
avogelsgesang added a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122102/new/
https://reviews.llvm.org/D122102
___
cfe-comm
avogelsgesang created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman, mgorny.
Herald added a project: All.
avogelsgesang requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This commit
