[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

2022-03-21 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7f7f4be78abc: [Clang] Set -mlinker-version explicitly in the lto test (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122110/new/ https:

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

2022-03-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D122110#3395427 , @int3 wrote: > Ohh gotcha. So clang assumes that the platform linker's version is at least > as high as the host linker's, assuming the host linker is ld64. That seems > kind of hacky, but I suppose it's exis

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

2022-03-20 Thread Jez Ng via Phabricator via cfe-commits
int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. Ohh gotcha. So clang assumes that the platform linker's version is at least as high as the host linker's, assuming the host linker is ld64. That seems kind of hacky, but I suppose it's existing be

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

2022-03-20 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D122110#3395336 , @int3 wrote: > Would it make sense to have clang pass `-object_path_lto` whenever it's > invoking LLD? It already does, see https://github.com/llvm/llvm-project/blob/afc2f024462951d6e74c5e733f4b4666e21d3309/

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

2022-03-20 Thread Jez Ng via Phabricator via cfe-commits
int3 added a comment. Would it make sense to have clang pass `-object_path_lto` whenever it's invoking LLD? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122110/new/ https://reviews.llvm.org/D122110 ___

[PATCH] D122110: [Clang] Set -mlinker-version explicitly in the lto test

2022-03-20 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: smeenai, int3, oontvoo, thakis. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Thi