This revision was automatically updated to reflect the committed changes.
fwolff marked an inline comment as done.
Closed by commit rG07675b0b38e9: [clang-tidy] Fix false positives in
`misc-redundant-expression` check (authored by fwolff).
Changed prior to commit:
https://reviews.llvm.org/D1221
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Please also add a release note for the fix when you land it.
Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:605
+ unl
fwolff marked an inline comment as done.
fwolff added a comment.
Thanks for the quick review @aaron.ballman! I think I've addressed your
comments.
Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:605
+ unless(isMacro()), unless(isInTemplateIn
fwolff updated this revision to Diff 417054.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122111/new/
https://reviews.llvm.org/D122111
Files:
clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
clang-tools-extra/test/clang-tidy/checkers/misc-redundant-expression.cpp
Inde
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:605
+ unless(isMacro()), unless(isInTemplateInstantiation()),
+ hasRHS(ignoringParenImpCasts(integerLiteral().bind(ConstId
.bind(Overlo
fwolff created this revision.
fwolff added reviewers: alexfh, aaron.ballman, pavelkryukov.
fwolff added a project: clang-tools-extra.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
fwolff requested review of this revision.
Herald added a subscriber: cfe-commits.
I
