This revision was automatically updated to reflect the committed changes.
Closed by commit rGd9739f29cdd4: Serialize PragmaAssumeNonNullLoc to support
preambles (authored by dgoldman).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https:
sammccall added a comment.
(Just checking you've seen this is accepted and you can land when you're ready!)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https://reviews.llvm.org/D122179
___
dgoldman updated this revision to Diff 418950.
dgoldman added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https://reviews.llvm.org/D122179
Files:
clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
clang/inc
dgoldman updated this revision to Diff 418301.
dgoldman added a comment.
Revert comment change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https://reviews.llvm.org/D122179
Files:
clang-tools-extra/clangd/unittests/DiagnosticsTests.
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks, this looks really solid now!
Comment at: clang/lib/Lex/PPLexerChange.cpp:430
- // Complain about reaching a true EOF within assume_nonnull.
+ // Complain ab
dgoldman updated this revision to Diff 418030.
dgoldman added a comment.
Another formatting fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https://reviews.llvm.org/D122179
Files:
clang-tools-extra/clangd/unittests/DiagnosticsTests
dgoldman updated this revision to Diff 418004.
dgoldman added a comment.
if/else formatting
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https://reviews.llvm.org/D122179
Files:
clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
dgoldman updated this revision to Diff 418001.
dgoldman added a comment.
Minor lint fixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https://reviews.llvm.org/D122179
Files:
clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp
dgoldman added inline comments.
Comment at: clang/lib/Lex/PPLexerChange.cpp:436
+ if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble &&
+ !(CurLexer && CurLexer->getFileID() == PredefinesFileID) &&
!isEndOfMacro && !(CurLexer && CurLexer->Is_Prag
dgoldman updated this revision to Diff 417976.
dgoldman marked an inline comment as done.
dgoldman added a comment.
Properly handle generation and restoring
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https://reviews.llvm.org/D122179
sammccall added inline comments.
Comment at: clang/lib/Lex/PPLexerChange.cpp:436
+ if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble &&
+ !(CurLexer && CurLexer->getFileID() == PredefinesFileID) &&
!isEndOfMacro && !(CurLexer && CurLexer->Is_Pra
dgoldman added inline comments.
Comment at: clang/lib/Lex/PPLexerChange.cpp:436
+ if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble &&
+ !(CurLexer && CurLexer->getFileID() == PredefinesFileID) &&
!isEndOfMacro && !(CurLexer && CurLexer->Is_Prag
sammccall added inline comments.
Comment at: clang/lib/Lex/PPLexerChange.cpp:436
+ if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble &&
+ !(CurLexer && CurLexer->getFileID() == PredefinesFileID) &&
!isEndOfMacro && !(CurLexer && CurLexer->Is_Pra
sammccall added inline comments.
Comment at: clang/lib/Lex/PPLexerChange.cpp:436
+ if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble &&
+ !(CurLexer && CurLexer->getFileID() == PredefinesFileID) &&
!isEndOfMacro && !(CurLexer && CurLexer->Is_Pra
dgoldman marked an inline comment as done.
dgoldman added inline comments.
Comment at: clang/lib/Lex/PPLexerChange.cpp:436
+ if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble &&
+ !(CurLexer && CurLexer->getFileID() == PredefinesFileID) &&
!isEn
dgoldman updated this revision to Diff 417623.
dgoldman marked 2 inline comments as done.
dgoldman added a comment.
Minor fixes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https://reviews.llvm.org/D122179
Files:
clang-tools-extra/c
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:755
+)cpp");
+ TU.Filename = "foo.m";
+ auto AST = TU.build();
nit: not necessary, this pragma isn't tied to objc
Comment at: clang-tools-ext
dgoldman added inline comments.
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:748
+TEST(DiagnosticsTest, PreambleWithPragmaAssumeNonnull) {
+ Annotations Header(R"cpp(
sammccall wrote:
> sammccall wrote:
> > This test seems to have a lot
dgoldman updated this revision to Diff 417315.
dgoldman marked 9 inline comments as done.
dgoldman added a comment.
Fixes for review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https://reviews.llvm.org/D122179
Files:
clang-tools-ex
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:748
+TEST(DiagnosticsTest, PreambleWithPragmaAssumeNonnull) {
+ Annotations Header(R"cpp(
This test seems to have a lot of extraneous elements.
The following
dgoldman added a comment.
LMK if there are other folks more suited to review this, I'm not sure...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122179/new/
https://reviews.llvm.org/D122179
___
cfe-commi
dgoldman created this revision.
dgoldman added reviewers: sammccall, doug.gregor.
Herald added subscribers: usaxena95, kadircet, arphaman.
Herald added a project: All.
dgoldman requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added projects: clang, cla
22 matches
Mail list logo
