[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2e56b70e2f: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement (authored by nickdesaulniers). Repository: rG LLVM Github

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers updated this revision to Diff 417661. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - fix incorrect REQUIRES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122189/new/ https://reviews.llvm.org/D12

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This LGTM with the test only requiring Arm. Please mention in the commit that it is possible to ignore this warning in system headers, but we chose not to because of potential fa

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers added a comment. In D122189#3399836 , @DavidSpickett wrote: > Can you post a bit of the header diff before/after? I think I know what it > looks like but just to be sure. Before: #define __noswap_splat_lane_f16(__p0,__p1) __extension__

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers updated this revision to Diff 417328. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - add comments, remove test requirement on 64b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122189/new/ https:

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

DavidSpickett added a comment. Can you post a bit of the header diff before/after? I think I know what it looks like but just to be sure. Comment at: clang/test/Sema/arm-neon-decl-after-stmt.c:3 +// RUN: -Wdeclaration-after-statement -fsyntax-only -verify %s +// REQUIRES: aar

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nathanchance added a comment. This passes through all my `ARCH=arm` and `ARCH=arm64` build and boot tests on `next-20220321` with the instances of `-Wdeclaration-after-statement` resolved and no new instances of any other warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers updated this revision to Diff 417116. nickdesaulniers added a comment. - rebase on main, don't mass refomat tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122189/new/ https://reviews.llvm.org/D122189 Files: clang/test/CodeGe

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers created this revision. nickdesaulniers added a reviewer: DavidSpickett. Herald added a subscriber: kristof.beyls. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The generated arm