[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

2022-03-22 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `HeaderSearch` currently assumes `LookupFileCache` is eventually populated in `LookupFile`. However, that's not a

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

2022-03-22 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I think this ends up being the same as what we came up with internally, so I think this LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122237/new/ https://reviews.llvm.org/D122237 _

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

2022-03-22 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122237/new/ https://reviews.llvm.org/D122237 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

2022-03-23 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 417527. jansvoboda11 added a comment. Remove slash from test to make it pass on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122237/new/ https://reviews.llvm.org/D122237 Files: clang/lib/Lex/He

[PATCH] D122237: [clang][lex] Fix failures with Microsoft header search rules

2022-03-23 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG59dadd178b0b: [clang][lex] Fix failures with Microsoft header search rules (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122237/n