int3 updated this revision to Diff 423532.
int3 added a comment.
Herald added a subscriber: dexonsmith.
- Use a separate ForceDwarfUnwindInfo flag
- Fix the remaining tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122258/new/
int3 marked an inline comment as done.
int3 added inline comments.
Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RTDyldMemoryManager.cpp:131-132
+ size_t Size) {
+ if (Size == 0)
+return;
registerEHFramesInProcess(Addr, Size);
int3 added a comment.
I'm currently working on the eh_frame support in LLD itself, but will circle
back to this diff in a week or so. Thanks for the feedback!
Comment at:
clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:48
+// FIXME
lhames added a comment.
> I'm currently doing that via MCContext::getGenDwarfForAssembly...
This isn't my wheelhouse, but at first glance GenDwarfForAssembly looks like it
might control all Dwarf sections (including debug ones). If that's the case you
might need to introduce something eh-frame
int3 added inline comments.
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:66-67
- if (T.isWatchABI())
-OmitDwarfIfHaveCompactUnwind = true;
@MaskRay
> I vaguely remember there is a place where DWARF unwind info is enabled for
> all but few environments
MaskRay added a comment.
> Previously, omitting unnecessary DWARF unwinds was only done for watchOS,
I have looked at compact unwind descriptors in 2020-11 to write
https://maskray.me/blog/2020-11-08-stack-unwinding#compact-unwind-descriptors
I vaguely remember there is a place where DWARF
int3 created this revision.
int3 added reviewers: davide, kledzik, lhames.
Herald added subscribers: StephenFan, cmtice, hiraditya, kristof.beyls, emaste.
Herald added a reviewer: JDevlieghere.
Herald added a reviewer: jhenderson.
Herald added a project: All.
int3 requested review of this
