[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

jyknight added a comment. > no-compact-unwind is particularly useful for newer x86_64 platforms: we don't > want to omit DWARF unwind for x86_64 in general due to possible backwards > compat issues, but we should make it possible for people to opt into this > behavior if they are only targeting

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

thakis added a comment. In D122258#3478727 , @davide wrote: > Compact unwind was developed as a goal to replace the DWARF unwind. Some apps > did not work if the OS was missing DWARF unwind, so we kept both for Intel. > The binary compatibility issue is

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

uabelho added inline comments. Comment at: clang/tools/driver/cc1as_main.cpp:323-329 + if (auto *A = Args.getLastArg(OPT_femit_dwarf_unwind_EQ)) { +Opts.EmitDwarfUnwind = +llvm::StringSwitch(A->getValue()) +.Case("always", EmitDwarfUnwindType::Always) +

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/tools/driver/cc1as_main.cpp:323-329 + if (auto *A = Args.getLastArg(OPT_femit_dwarf_unwind_EQ)) { +Opts.EmitDwarfUnwind = +llvm::StringSwitch(A->getValue()) +.Case("always", EmitDwarfUnwindType::Always) +

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. Actually let me try it now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. Oh dear. Hmm does running the test with ASAN enabled hit any memory issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___ cfe-commit

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

uabelho added a comment. Hi, I noticed that on one of our downstream (not public) buildbots the clang/test/Driver/femit-dwarf-unwind.s test seems to fail rather randomly. So if I run clang -target x86_64-apple-macos11.0 -c ../clang/test/Driver/femit-dwarf-unwind.s -o foo.o llvm-objdump

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. d'oh, I see it now. And of course the parent `llvm/test/MC/MachO` directory is gated to x86-only. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

thakis added a comment. I think it should work if you put the test in llvm/test/MC/MachO/AArch64 instead of in llvm/test/MC/MachO, because of: % cat llvm/test/MC/MachO/AArch64/lit.local.cfg if not 'AArch64' in config.root.targets: config.unsupported = True Repository: rG LLVM Gith

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added a comment. Buildbots gave me a bunch of errors of the form /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/llvm-mc: error: unable to get target for 'arm64-apple-macos11.0', see --version and --triple. I'm wondering if I'm just missing a REQUIRES line, but th

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef501bf85d8c: [MC] Omit DWARF unwind info if compact unwind is present where eligible (authored by int3). Changed prior to commit: https://reviews

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 marked 3 inline comments as done. int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCR

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427509. int3 added a comment. make things work under cc1as too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def cl

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll; ---

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll; ---

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll; ---

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427398. int3 added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427396. int3 retitled this revision from "[MC] Omit DWARF unwind info if compact unwind is present for all archs" to "[MC] Omit DWARF unwind info if compact unwind is present where eligible". int3 edited the summary of this revision. int3 added a comment. Herald