[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG528e6eba2f79: [clang] Improve diagnostic for reopened inline namespace (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D122278?vs=417455=417749#toc Repository: rG LLVM Github

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

aaron.ballman added a comment. Thank you for the fix! This LGTM with a minor nit, but please also add a release note for the fix. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11062-11066 + if (auto *FirstNS = PrevNS->getFirstDecl()) +// 'inline' must appear on the original

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. This looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122278/new/ https://reviews.llvm.org/D122278

[PATCH] D122278: [clang] Improve diagnostic for reopened inline namespace

fwolff created this revision. fwolff added reviewers: rsmith, cor3ntin, mizvekov. fwolff added a project: clang. Herald added a project: All. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes #50794 .