This revision was automatically updated to reflect the committed changes.
Closed by commit rG67d9276b1602: [clang-cl] Ignore /Wv and /Wv:17 flags
(authored by thieta).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122298/new/
https://reviews.llvm.or
hans accepted this revision.
hans added a comment.
Looks great, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122298/new/
https://reviews.llvm.org/D122298
___
cfe-commits mailing list
cfe-commits
thieta added a comment.
Pushed the whitespace fix as a NFC here:
https://github.com/llvm/llvm-project/commit/09c0685a043dd4028545c134b562c2605e294855
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122298/new/
https://reviews.llvm.org/D122298
_
thieta updated this revision to Diff 417537.
thieta added a comment.
Split whitespace to it's own commit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122298/new/
https://reviews.llvm.org/D122298
Files:
clang/include/clang/Driver/Options.td
cl
mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.
The patch itself seems sensible to me.
Comment at: clang/include/clang/Driver/Options.td:2496
Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
-def fopenmp_ass
thieta added inline comments.
Comment at: clang/include/clang/Driver/Options.td:2496
Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>;
-def fopenmp_assume_no_thread_state : Flag<["-"],
"fopenmp-assume-no-thread-state">, Group,
- Flags<[CC1Option, NoArgumentUnused, He
thieta updated this revision to Diff 417533.
thieta added a comment.
Added back removed blank line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122298/new/
https://reviews.llvm.org/D122298
Files:
clang/include/clang/Driver/Options.td
clang/te
thieta created this revision.
thieta added reviewers: hans, mstorsjo, rnk.
Herald added a project: All.
thieta requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
Herald added a project: clang.
MSVC supports passing /Wv and /Wv:17 to ignore w
