[PATCH] D122378: Be more explicit about -fvisibility= documentation

2022-03-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille added a comment. thanks for the guidance. I'll check if I can update tablegen to generate possible options then :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122378/new/ https://reviews.llvm.org/D122378

[PATCH] D122378: Be more explicit about -fvisibility= documentation

2022-03-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Btw, you're changing a generated .rst file. You need to fix up the documentation in Options.td which is used to generate this .rst file. I don't know that you'll be

[PATCH] D122378: Be more explicit about -fvisibility= documentation

2022-03-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thanks for the additional docs! Comment at: clang/docs/ClangCommandLineReference.rst:2616 -.. option:: -fvisibility= +.. option:: -fvisibility=[default|hidden] From looking at Options.td, it seems there are more visibility

[PATCH] D122378: Be more explicit about -fvisibility= documentation

2022-03-24 Thread serge via Phabricator via cfe-commits
serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When in need, I had to look into gcc info page, then