bsmith accepted this revision.
bsmith added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122732/new/
https://reviews.llvm.org/D122732
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rG53fd8db79192: [Clang][AArch64][SVE] Allow subscript operator
for SVE types (authored by DavidTruby).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122732/new
DavidTruby created this revision.
Herald added subscribers: psnobl, kristof.beyls, tschuett.
Herald added a reviewer: efriedma.
Herald added a project: All.
DavidTruby requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Undefined behaviour is j
efriedma added a comment.
> Subscript on svbool_t is not allowed as this doesn't really have meaningful
> semantics.
Not sure what you mean by this; LLVM supports extractelement on `` vectors. I guess the fact that it's a "vscale x 16" element vector might
not be intuitive?
Repository:
rG
DavidTruby added a comment.
> Not sure what you mean by this; LLVM supports extractelement on ` x i1>` vectors. I guess the fact that it's a "vscale x 16" element vector
> might not be intuitive?
It's a native operation at the LLVM level but not at the ISA level, unlike the
data registers. Cod