[PATCH] D122734: [HIP] Fix mangling number for local struct

2022-04-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D122734#3437344 , @tra wrote: > In D122734#3435086 , @yaxunl wrote: > >> This patch takes a similar approach as https://reviews.llvm.org/D69322 has >> done for lambda. When doing host

[PATCH] D122734: [HIP] Fix mangling number for local struct

2022-04-07 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D122734#3435086 , @yaxunl wrote: > This patch takes a similar approach as https://reviews.llvm.org/D69322 has > done for lambda. When doing host compilation for CUDA/HIP on Windows with > MSVC toolchain, mangling number of

[PATCH] D122734: [HIP] Fix mangling number for local struct

2022-04-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. This patch takes a similar approach as https://reviews.llvm.org/D69322 has done for lambda. When doing host compilation for CUDA/HIP on Windows with MSVC toolchain, mangling number of lambda always uses Itanium mangling number. In this case, mangling number of local

[PATCH] D122734: [HIP] Fix mangling number for local struct

2022-04-06 Thread Artem Belevich via Phabricator via cfe-commits
tra added subscribers: rnk, rsmith. tra added a comment. @rnk, @rsmith -- PTAL. Changing mangling for CXXABI on Windows is way out of my comfort zone. > This patch uses Itanium mangling number for structs in HIP host compilation > on Windows to fix this issue. It does not appear to be

[PATCH] D122734: [HIP] Fix mangling number for local struct

2022-04-06 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122734/new/ https://reviews.llvm.org/D122734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D122734: [HIP] Fix mangling number for local struct

2022-03-30 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added a project: All. yaxunl requested review of this revision. MSVC and Itanium mangling use different mangling numbers for function-scope structs, which causes inconsistent mangled kernel names in device and host