jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3062
+if (auto *A = Global->getAttr())
+ VariantGlobalsEmitted.insert(A->getFunction());
}
jhuber6 wrote:
> jdoerfert wrote:
> > This looks like you now disable the
jhuber6 updated this revision to Diff 420608.
jhuber6 added a comment.
Make suggested changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122760/new/
https://reviews.llvm.org/D122760
Files:
clang/include/clang/Basic/Attr.td
jhuber6 marked an inline comment as done.
jhuber6 added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3062
+if (auto *A = Global->getAttr())
+ VariantGlobalsEmitted.insert(A->getFunction());
}
jdoerfert wrote:
> This looks like you
jdoerfert added a comment.
There is no documentation of the extension and attribute. See also below.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1459
+ if (auto *A = ND->getAttr())
+ND = A->getFunction();
std::string MangledName = getMangledNameImpl(*this, GD, ND);
jhuber6 updated this revision to Diff 420604.
jhuber6 added a comment.
Updating to stop erroring if a function with the same mangled error exists, but
is never emitted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122760/new/
jhuber6 updated this revision to Diff 419567.
jhuber6 added a comment.
Herald added a reviewer: aaron.ballman.
Updating to use an attribute instead to get around the loss of the identifier
info when using PCH. Unfortunately this still causes problems when using PCH.
Repository:
rG LLVM
jhuber6 added a comment.
The test currently fails because we don't do the stripping when we emit the
precompiled header, it will simply be imported using the mangled version and it
will not have in the original input info associated with it. I will need to
figure out where we emit the PCH
jhuber6 created this revision.
jhuber6 added a reviewer: jdoerfert.
Herald added subscribers: asavonic, dexonsmith, guansong, yaxunl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: llvm-commits, cfe-commits, sstefan1.
Herald added projects: clang,
