[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG15a1769631ff: Emit OpenCL metadata when targeting SPIR-V (authored by shangwuyao). Repository: rG LLVM Github Monorepo

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

yaxunl added a comment. LGTM since currently there is only one HIP/SPIRV implementation. If in the future there is another HIP/SPIRV implementation that does not need this, it could disable it by triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

shangwuyao added a comment. In D123049#3426849 , @yaxunl wrote: > Is this because your HIP threadIdx etc are implemented using OpenCL builtins > so that the emitted LLVM IR contains calls of OpenCL builtins? Yes, that's correct. Repository: rG LLVM

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

yaxunl added a comment. Is this because your HIP threadIdx etc are implemented using OpenCL builtins so that the emitted LLVM IR contains calls of OpenCL builtins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123049/new/ https://reviews.llvm.org/

[PATCH] D123049: Emit OpenCL metadata when targeting SPIR-V

shangwuyao created this revision. shangwuyao added reviewers: jlebar, yaxunl, tra. Herald added subscribers: ldrumm, ThomasRaoux, Anastasia. Herald added a project: All. shangwuyao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is req