[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

2022-05-05 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added a comment. In D123200#3495356 , @aykevl wrote: > @benshi001 I have been looking through the GCC code and I think avr-gcc also > has a special calling convention for many other functions, including > `__mulqi3` and `__mulhi3`. > > Source:

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

2022-05-05 Thread Ayke via Phabricator via cfe-commits
aykevl added a comment. @benshi001 I have been looking through the GCC code and I think avr-gcc also has a special calling convention for many other functions, including `__mulqi3` and `__mulhi3`. Source: 1. I think this is where the ABI is specified in the compiler: https://github.com/gcc-mi

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

2022-05-01 Thread Ben Shi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. benshi001 marked an inline comment as done. Closed by commit rGfb7a435492a5: [compiler-rt][builtins] Add several helper functions for AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D123200?

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

2022-05-01 Thread Ben Shi via Phabricator via cfe-commits
benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:671 +set(avr_SOURCES + avr/mulqi3.S MaskRay wrote: > Keep the `*_SOURCES` in alphabetical order. Move avr to the beginning. Ignore

[PATCH] D123200: [compiler-rt][builtins] Add several helper functions for AVR

2022-04-30 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:171 check_symbol_exists(__ve__ "" __VE) + check_symbol_exists(__AVR__ "" __AVR) if(__ARM) ---