[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

2022-05-10 Thread Jan Korous via Phabricator via cfe-commits
jkorous added a comment. Reverting for now. Will take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123273/new/ https://reviews.llvm.org/D123273 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

2022-05-10 Thread Jake Egan via Phabricator via cfe-commits
Jake-Egan added a comment. 4 of the tests fail on AIX also: https://lab.llvm.org/buildbot/#/builders/214/builds/1207 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123273/new/ https://reviews.llvm.org/D123273 __

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

2022-05-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Also fails on linux: https://lab.llvm.org/buildbot/#/builders/109/builds/38285 And on mac: http://45.33.8.238/macm1/35024/step_7.txt (On some platforms, the bot redness was masked by D124552 breaking the bots first.) But yes, please fi

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

2022-05-10 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. Hi @jkorous, 4 of the tests you added seem to be failing on the PS4 linux and Window buildbots, can you take a look, and revert if it might take a while to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/21573 https://lab.llvm.org/buildbot/#/builders/216/

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

2022-05-10 Thread Jan Korous via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce583b14b2ec: [utils] Avoid hardcoding metadata ids in update_cc_test_checks (authored by jkorous). Herald added a project: clang. Herald added a sub