[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca27f3e3b26e: [Clang][OpenMP] Support for omp nothing (authored by koops, committed by Chi-Chun, Chen ). Repository: rG

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123286/new/ https://reviews.llvm.org/D123286 ___ cfe-commits mailing list

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

koops added a comment. In D123286#3527374 , @koops wrote: > In D123286#3513797 , > @tianshilei1992 wrote: > >> Can we have test for right usage? > > I do not understand "test for right usage". From the specific

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

koops added a comment. In D123286#3513797 , @tianshilei1992 wrote: > Can we have test for right usage? I do not understand "test for right usage". From the specifications the only right usage for "omp nothing" will be in the metadirective. If you have

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

koops updated this revision to Diff 430933. koops added a comment. changes to support clang format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123286/new/ https://reviews.llvm.org/D123286 Files: clang/lib/Basic/OpenMPKinds.cpp clang/lib/Parse/ParseOpenMP.cpp clang/test/OpenMP/

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

tianshilei1992 added a comment. Can we have test for right usage? Comment at: clang/lib/Parse/ParseOpenMP.cpp:2496 +<< getOpenMPDirectiveName(DKind) << 0; +} +ConsumeToken(); clang-format plz, and remove the `{` and `}` as there is only one stat