[PATCH] D123325: [Clang] Make enabling the new driver more generic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e2b5a6693e2: [Clang] Make enabling the new driver more generic (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D123325?v

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 425879. jhuber6 added a comment. Changin `-f[no-]offload-new-driver` into `--[no-]offload-new-driver` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/i

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_new_driver : Flag<["-"], "foffload-new-driver">, Flags<[CC1Option]>, Group, + HelpText<"Use the new driver for offloading compilation.">; +def fno_offload_new_driver : Flag<

[PATCH] D123325: [Clang] Make enabling the new driver more generic

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_new_driver : Flag<["-"], "foffload-new-driver">, Flags<[CC1Option]>, Group, + HelpText<"Use the new driver for offloading compilation.">; +def fno_offload_new_driver : Flag<["-"

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_new_driver : Flag<["-"], "foffload-new-driver">, Flags<[CC1Option]>, Group, + HelpText<"Use the new driver for offloading compilation.">; +def fno_offload_new_driver : Flag<

[PATCH] D123325: [Clang] Make enabling the new driver more generic

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:2535-2538 +def foffload_new_driver : Flag<["-"], "foffload-new-driver">, Flags<[CC1Option]>, Group, + HelpText<"Use the new driver for offloading compilation.">; +def fno_offload_new_driver : Flag<["-"

[PATCH] D123325: [Clang] Make enabling the new driver more generic

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 __

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 425785. jhuber6 added a comment. Ping and update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Dr

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added a comment. In D123325#3459108 , @yaxunl wrote: > should we have a test to show the effect of -foffload-new-driver on > -ccc-print-phases for CUDA/HIP? I decided to add the test in D120272 because this fi

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added a comment. In D123325#3459108 , @yaxunl wrote: > should we have a test to show the effect of -foffload-new-driver on > -ccc-print-phases for CUDA/HIP? We probably should, it's tested w/ OpenMP but we should check the bound architectures a

[PATCH] D123325: [Clang] Make enabling the new driver more generic

yaxunl added a comment. should we have a test to show the effect of -foffload-new-driver on -ccc-print-phases for CUDA/HIP? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 ___

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423514. jhuber6 added a comment. Removing unnecessary change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423479. jhuber6 added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Compilation.h clang/include/clang/Driver/Op

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 423459. jhuber6 added a comment. Rebase & update after making the new driver default for OpenMP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/includ

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3885-3888 + bool UseNewOffloadingDriver = + C.isOffloadingHostKind(C.getActiveOffloadKinds()) && + (Args.hasArg(options::OPT_foffload_new_driver) || + Args.hasArg(options::OPT_fopenmp_new_driv

[PATCH] D123325: [Clang] Make enabling the new driver more generic

yaxunl added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3885-3888 + bool UseNewOffloadingDriver = + C.isOffloadingHostKind(C.getActiveOffloadKinds()) && + (Args.hasArg(options::OPT_foffload_new_driver) || + Args.hasArg(options::OPT_fopenmp_new_drive

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 421607. jhuber6 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Compilation.h clang/include/clang/Drive

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 updated this revision to Diff 421595. jhuber6 added a comment. Fix misplaced logic symbol that broke tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 Files: clang/include/clang/Driver/Comp

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, yaxunl, tra. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. In preparation for allowing other offloa