[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Daniel Grumberg via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80ae36659292: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph (authored by dang). Repository: rG LLVM Github Monorepo CH

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Victoria Mitchell via Phabricator via cfe-commits
QuietMisdreavus accepted this revision. QuietMisdreavus added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123391/new/ https://reviews.llvm.org/D123391 _

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 421537. dang added a comment. Add test to check that ObjC methods with multiple external parameters get the correct name in subHeadings and navigator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123391/new/ http

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Victoria Mitchell via Phabricator via cfe-commits
QuietMisdreavus added a comment. This looks good! Just one question. Comment at: clang/test/ExtractAPI/objc_interface.m:198 +"kind": "identifier", +"spelling": "getWithProperty:" + } I'm curious: Does this properly handle Object

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

2022-04-08 Thread Daniel Grumberg via Phabricator via cfe-commits
dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123391 Files: cl