[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

lenary added a comment. Oh, can you close this revision and link it to the landed commit please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 ___

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam added a comment. In D123630#3899550 , @lenary wrote: > Reverse ping. This has been accepted, what is the status of landing this? As far as I can tell this has landed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

lenary added a comment. Reverse ping. This has been accepted, what is the status of landing this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 ___ cfe-commits mailing list

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 460470. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a few nits. Comment at: clang/docs/UsersManual.rst:1411 + Note: ``-ffast-math`` causes ``crtfastmath.o`` to be linked with code. + Comment at:

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 460389. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contract-option.c

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

jcranmer-intel accepted this revision. jcranmer-intel added a comment. This revision is now accepted and ready to land. I'm happy with these changes. I'll let Aaron have one last crack at the wording of the documentation, in case there's any minor editorial stuff he'd like to see cleaned up.

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 460178. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contract-option.c

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam added inline comments. Comment at: clang/docs/UsersManual.rst:1453-1455 + Note: ``DenormalFPMath`` and ``DenormalFP32Math`` are set by default to IEEE + (no flush) for ``-fno-fast-math``, ``-fno-unsafe-math-optimizations``, and + any setting of ``fp-model``. Clang

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 459893. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

jcranmer-intel added inline comments. Comment at: clang/docs/UsersManual.rst:1430 + + * ``-ffp-contract=on`` + You can add `-fdenormal-fp-math=ieee` here. Comment at: clang/docs/UsersManual.rst:1453-1455 + Note: ``DenormalFPMath`` and

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 459028. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

jcranmer-intel added a comment. Some general comments on the documentation here: One of the lesser-known issues of `-ffast-math` is the fact that it (or `-funsafe-math-optimizations`) causes `crtfastmath.o` to be linked, which adds a static constructor that sets the FTZ/DAZ bits in MXCSR,

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam added a comment. Thanks @aaron.ballman! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 458506. zahiraam marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

aaron.ballman added a reviewer: jcranmer-intel. aaron.ballman added a comment. I made some suggested documentation changes, but would love to hear more from folks heavily into floating-point options. Comment at: clang/docs/UsersManual.rst:1409-1410 + Disable fast-math mode.

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam added a comment. @fhahn @aaron.ballman would you mind taking time for a review for this patch? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 ___ cfe-commits mailing list

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 457358. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contract-option.c

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

aaron.ballman added a comment. I think these changes should go through a community RFC on Discourse given that they alter the behavior of existing flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam created this revision. zahiraam added reviewers: aaron.ballman, andrew.w.kaylor, rjmccall, joerg, efriedma. Herald added a project: All. zahiraam requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Currently the options ‘ffast-math’ and