[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 closed this revision. jansvoboda11 added a comment. Re-committed as d9390b6ac387345e7d3348bfc648929bc349d6b1 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 updated this revision to Diff 436380. jansvoboda11 added a comment. Replace the `Dir = File->getLastRef().getDir();` escape hatch with `FileMgr.getOptionalDirectoryRef(File->getDir()->getName())`. The former was causing failures in `clang/test/VFS/real-path-found-first.m` on

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d3ba05e4a28: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*() (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

bnbarham accepted this revision. bnbarham added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/HeaderSearch.cpp:1583 +::getTopFrameworkDir(FileMgr, FrameworkName, SubmodulePath); +assert(TopFrameworkDir && "Could not find

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 updated this revision to Diff 423084. jansvoboda11 marked 5 inline comments as done. jansvoboda11 added a comment. Rebase, address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123771/new/

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 marked 5 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:339 // Search for a module map file in this directory. -if (loadModuleMapFile(Dir.getDir(), IsSystem, +if

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

bnbarham added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:339 // Search for a module map file in this directory. -if (loadModuleMapFile(Dir.getDir(), IsSystem, +if (loadModuleMapFile(*Dir.getDirRef(), IsSystem,

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, bnbarham. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes uses of the deprecated