This revision was automatically updated to reflect the committed changes.
Closed by commit rG1234b1c6d811: [AST] Support template declaration found
through using-decl for… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D123775?vs=423843&id=424128#toc
Repository:
rG L
shafik added inline comments.
Comment at: clang/lib/Sema/SemaTemplate.cpp:1004
Name = Context.getQualifiedTemplateName(SS.getScopeRep(),
/*HasTemplateKeyword*/ false,
+Name);
hokein added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:9189
+TemplateName UnderlyingTN = QTN->getUnderlyingTemplate();
+if (UsingShadowDecl *USD = UnderlyingTN.getAsUsingShadowDecl()) {
+ if (ExpectedDecl ToUSDOrErr = Import(USD))
sa
hokein updated this revision to Diff 423843.
hokein marked an inline comment as done.
hokein added a comment.
simplify the code in ASTImporter.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123775/new/
https://reviews.llvm.org/D123775
Files:
cla
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/AST/ASTImporter.cpp:9189
+TemplateName UnderlyingTN = QTN->getUnderlyingTemplate();
+if (UsingShadowDecl *USD = UnderlyingTN.getAsUsin
hokein added inline comments.
Comment at: clang/include/clang/AST/PropertiesBase.td:666
}
- def : Property<"declaration", TemplateDeclRef> {
+ def : Property<"templateDecl", TemplateDeclRef> {
let Read = [{ qtn->getTemplateDecl() }];
sammccall wrote:
>
hokein updated this revision to Diff 423687.
hokein added a comment.
format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123775/new/
https://reviews.llvm.org/D123775
Files:
clang/include/clang/AST/ASTContext.h
clang/include/clang/AST/Properti
hokein updated this revision to Diff 423686.
hokein marked 6 inline comments as done.
hokein added a comment.
expose underlying template name, removed the getUsingShadowDecl;
address comments;
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123775/new
sammccall added inline comments.
Comment at: clang/include/clang/AST/PropertiesBase.td:666
}
- def : Property<"declaration", TemplateDeclRef> {
+ def : Property<"templateDecl", TemplateDeclRef> {
let Read = [{ qtn->getTemplateDecl() }];
this seems to be
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a subscriber: martong.
Herald added a reviewer: shafik.
Herald added a project: All.
hokein requested review of this revision.
Herald added a project: clang.
This is a followup of https://reviews.llvm.org/D123127, addin
10 matches
Mail list logo