pzheng added a comment.
Thanks for the heads-up, @thakis. I have reverted the patch for now and will
try to reproduce the failure.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124032/new/
https://reviews.llvm.org/D124032
thakis added a comment.
As far as I can tell, this broke tests everywhere, e.g.
http://45.33.8.238/linux/74221/step_7.txt
https://lab.llvm.org/buildbot/#/builders/109/builds/36986 etc
Please take a look, and revert for now if it takes a while to fix.
Repository:
rG LLVM Github Monorepo
CHA
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8a9b4fb4aa6d: [COFF, ARM64] Add __break intrinsic (authored
by pzheng).
Changed prior to commit:
https://reviews.llvm.org/D124032?vs=423754&id=423
mstorsjo accepted this revision.
mstorsjo added a comment.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124032/new/
https://reviews.llvm.org/D124032
___
cfe-commits mailing list
cfe-commit
pzheng added a comment.
Thanks for reviewing the patch, @rnk.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124032/new/
https://reviews.llvm.org/D124032
___
cfe-commits mailing list
cfe-commits@lists.llv
pzheng updated this revision to Diff 423754.
pzheng added a comment.
Address comments from @mstorsjo.
Thanks for catching the missing test, @mstorsjo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124032/new/
https://reviews.llvm.org/D124032
File
mstorsjo added a comment.
Should there be tests for the LLVM side of this too, not only on the clang side?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124032/new/
https://reviews.llvm.org/D124032
___
c
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124032/new/
https://reviews.llvm.org/D124032
___
cfe-c
pzheng created this revision.
pzheng added reviewers: rnk, mstorsjo, efriedma.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
pzheng requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
https:/