[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm added a comment. close with clang format at commit 6454ff35e0e7b0c0762c640031aa6c2b5d1f16ec [Clang Format] emmintrin.h smmintrin.h (NFC) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafa536e33e10: [x86] Support 3 builtin functions for 32-bits mode (authored by xiangzhangllvm). Herald added a project: clang. Changed prior to commi

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm marked an inline comment as done. xiangzhangllvm added inline comments. Comment at: clang/lib/Headers/emmintrin.h:3476 +/// This intrinsic corresponds to the VMOVQ / MOVQ instruction +/// in 64 bits. /// RKSimon wrote: > xiangzhangllvm wrote: >

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with one minor typo Comment at: clang/lib/Headers/emmintrin.h:3476 +/// This intrinsic corresponds to the VMOVQ / MOVQ instruction +/// in 64 bits. ///

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm marked an inline comment as done. xiangzhangllvm added inline comments. Comment at: clang/lib/Headers/emmintrin.h:3476 +/// This intrinsic corresponds to the VMOVQ / MOVQ instruction +/// in 64 bits. /// craig.topper wrote: > craig.topper wrote:

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm updated this revision to Diff 424113. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 Files: clang/include/clang/Basic/BuiltinsX86.def clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/emmintrin.h clang/lib/He

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

craig.topper added inline comments. Comment at: clang/lib/Headers/emmintrin.h:3476 +/// This intrinsic corresponds to the VMOVQ / MOVQ instruction +/// in 64 bits. /// craig.topper wrote: > 64 bits -> 64-bit mode 64 bits -> 64-bit CHANGES SINCE LAST ACTION

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm updated this revision to Diff 424070. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 Files: clang/include/clang/Basic/BuiltinsX86.def clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/emmintrin.h clang/lib/He

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm marked an inline comment as done. xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/sse2-builtins.c:547 // X64: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 // X64: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 return _mm_cvtsi6

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm updated this revision to Diff 424067. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 Files: clang/include/clang/Basic/BuiltinsX86.def clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/emmintrin.h clang/lib/He

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm added a comment. In D124067#3461551 , @RKSimon wrote: > OK - SSE2/SSE41 now have i386 coverage - please can you rebase and update the > checks to use CHECK/X64/X86 ? Hi @RKSimon, I very appreciate your help to update the test! You are ver

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

RKSimon added a comment. OK - SSE2/SSE41 now have i386 coverage - please can you rebase and update the checks to use CHECK/X64/X86 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 ___ cfe-commits m

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

RKSimon added a comment. I'm updating the sse builtin test files to include i386 coverage - should be done in an hour or so CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 ___ cfe-commits mailing li

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/sse2-builtins.c:560 // CHECK: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 + // X86-LABEL: test_mm_cvtsi64_si128 + // X86: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 LiuChen3 wr

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

LiuChen3 added inline comments. Comment at: clang/test/CodeGen/X86/sse2-builtins.c:560 // CHECK: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 + // X86-LABEL: test_mm_cvtsi64_si128 + // X86: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 xiangzhangllvm wr

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/sse2-builtins.c:560 // CHECK: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 + // X86-LABEL: test_mm_cvtsi64_si128 + // X86: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 xiangzhangl

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

xiangzhangllvm added inline comments. Comment at: clang/test/CodeGen/X86/sse2-builtins.c:560 // CHECK: insertelement <2 x i64> %{{.*}}, i64 0, i32 1 + // X86-LABEL: test_mm_cvtsi64_si128 + // X86: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0 RKSimon wro