This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGad46aaede6e4: [clangd] Add beforeExecute() callback to
FeatureModules. (authored by adamcz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
adamcz updated this revision to Diff 424215.
adamcz marked 5 inline comments as done.
adamcz added a comment.
addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124176/new/
https://reviews.llvm.org/D124176
Files:
clang-tools
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/FeatureModule.h:109
+// Called before the preamble build. Allows modules to modify the
+// CompilerInvocation
adamcz created this revision.
adamcz added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
Herald added a project: All.
adamcz requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
It runs i
