[PATCH] D124211: Add __builtin_call_kcfi_unchecked

samitolvanen updated this revision to Diff 426116. samitolvanen marked 2 inline comments as done. samitolvanen added a comment. - Renamed the builtin. - Addressed Nick's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124211/new/ https://re

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

rjmccall added a comment. My only comment about the design is that maybe it should be `__builtin_kcfi_call_unchecked`, which does not seem like something you need to hold up LKML discussion for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124211

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

samitolvanen added a comment. In D124211#3480773 , @nickdesaulniers wrote: > Perhaps it's time to start a discussion on LKML then, before landing this? I don't intend to land these patches until there's a consensus on the correct approach from both pro

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

nickdesaulniers added a comment. In D124211#3480709 , @samitolvanen wrote: > In D124211#3480652 , > @nickdesaulniers wrote: > >> Can you link to the lore thread on discussions around the builtin? > > There's no

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

samitolvanen added a comment. In D124211#3480652 , @nickdesaulniers wrote: > Can you link to the lore thread on discussions around the builtin? There's no LKML discussion about the built-in, but there were earlier proposals of using an attribute to acc

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:436 + + auto Call = dyn_cast_or_null(BuiltinCall->getArg(0)); + nickdesaulniers wrote: > `auto *Call =` > https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

nickdesaulniers added a comment. Can you link to the lore thread on discussions around the builtin? Comment at: clang/lib/Sema/SemaChecking.cpp:436 + + auto Call = dyn_cast_or_null(BuiltinCall->getArg(0)); + `auto *Call =` https://llvm.org/docs/CodingStandards

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

samitolvanen created this revision. samitolvanen added reviewers: aaron.ballman, pcc, nickdesaulniers, ardb, kees, joaomoreira. Herald added a project: All. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With `-fsanitize=kcfi