[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

beanz added a comment. I posted a PR to swift that migrates build-script to use `LLVM_ENABLE_RUNTIMES`: https://github.com/apple/swift/pull/58465 Obviously I can't test this against your internal infrastructure, but the change here is pretty trivial. Repository: rG LLVM Github Monorepo

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

beanz added a comment. Posted an RFC: https://discourse.llvm.org/t/rfc-deprecate-and-remove-llvm-build-external-compiler-rt/62058 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124474/new/ https://reviews.llvm.org/D124474

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

delcypher accepted this revision. delcypher added a comment. This revision is now accepted and ready to land. Change LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124474/new/ https://reviews.llvm.org/D124474

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

delcypher added a comment. > I'd definitely prefer moving towards LLVM_ENABLE_RUNTIMES. We already require > LLVM_ENABLE_RUNTIMES for libc++, libc++abi and libunwind and I'm going to > propose doing the same for compiler-rt as well. +1 on this. Compiler-RT's CMake code is extremely and

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

beanz added reviewers: compnerd, ldionne, smeenai. beanz added subscribers: smeenai, ldionne, compnerd. beanz added a comment. I don't want to roadblock or say "no we absolutely can't let this in", _but_... Apple Clang and Swift have long been the only reason we've kept this code alive. I

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

azharudd added a comment. In D124474#3475550 , @beanz wrote: > In D124474#3475539 , @azharudd > wrote: > >> In this case I'm just trying to make it work with existing build >> configurations where it is being

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

phosek added a comment. In D124474#3475550 , @beanz wrote: > In D124474#3475539 , @azharudd > wrote: > >> In this case I'm just trying to make it work with existing build >> configurations where it is being

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

beanz added a comment. In D124474#3475539 , @azharudd wrote: > In this case I'm just trying to make it work with existing build > configurations where it is being used (for example Swift). We should > definitely be moving away from

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

azharudd added a comment. In D124474#3475432 , @beanz wrote: > I question whether we should be extending this or killing it off... Is there > a reason you're using `LLVM_BUILD_EXTERNAL_COMPILER_RT` instead of > `LLVM_ENABLE_RUNTIMES=compiler-rt`? In

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

beanz added a comment. I question whether we should be extending this or killing it off... Is there a reason you're using `LLVM_BUILD_EXTERNAL_COMPILER_RT` instead of `LLVM_ENABLE_RUNTIMES=compiler-rt`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

azharudd created this revision. azharudd added reviewers: yln, delcypher, beanz, phosek. Herald added a subscriber: mgorny. Herald added a project: All. azharudd requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When building with