[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida created this revision. cishida added reviewers: ributzka, zixuw, jansvoboda11. Herald added a project: All. cishida requested review of this revision. Herald added a project: clang. tapi & clang-extractapi both attempt to construct then check against how a header was included to determine

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

zixuw accepted this revision. zixuw added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124638/new/ https://reviews.llvm.org/D124638 ___

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed. Can you describe how come the check is not reliable without this patch? It might be worth fixing the underlying reason for the unreliability first. Com

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

tschuett added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1036 + +// This file is a system header or C++ unfriendly if the dir is. HFI.DirInfo = CurDir->getDirCharacteristic(); Why did the comment move? Repository: rG LLVM Github Mon

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida added a comment. In D124638#3481932 , @jansvoboda11 wrote: > Can you describe how come the check is not reliable without this patch? It > might be worth fixing the underlying reason for the unreliability first. Different search paths alter wher

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:1036 + +// This file is a system header or C++ unfriendly if the dir is. HFI.DirInfo = CurDir->getDirCharacteristic(); tschuett wrote: > Why did the comment move? It refers to sett

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

cishida updated this revision to Diff 426858. cishida added a comment. Hold include name in `HeaderSearch` itself, keeping HeaderFileInfo lightweight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124638/new/ https://reviews.llvm.org/D124638 Files

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124638/new/ https://reviews.llvm.org/D124638 __

[PATCH] D124638: [clang] Track how headers get included generally during lookup time

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6c67c3c6789: [clang] Track how headers get included generally during lookup time (authored by cishida). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124638