[PATCH] D124669: [flang][driver] Add support for -save-temps

This revision was automatically updated to reflect the committed changes. Closed by commit rGa65afce731c2: [flang][driver] Add support for -save-temps (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D124669?vs=427367=427561#toc Repository: rG LLVM Github Monorepo

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski added a comment. Pre-merge CI is  . If there are no new comments, I'd like to merge this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 427367. awarzynski added a comment. Mark the tests as unsupported on Windows Pre-merge testing is failing on Windows. Here is the error message: flang-new: error: there is no external assembler that can be used on this platform I will update the

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 427333. awarzynski marked an inline comment as done. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 Files:

[PATCH] D124669: [flang][driver] Add support for -save-temps

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM, thanks! It would be nice to rebase the patch and see the pre-commit CI passing, but then again you're the one dealing with the buildbots if you break anything, so do as you prefer :)

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski marked 4 inline comments as done. awarzynski added inline comments. Comment at: flang/test/Driver/fno-integrated-as.f90:18 +! DEFAULT-LABEL: "-fc1" +! DEFAULT-SAME: "-o" "fno-integrated-as.o" "{{.*}}fno-integrated-as.f90" rovka wrote: > Nit (here and

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 427036. awarzynski added a comment. Fix typos as per comments from @rovka, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 Files:

[PATCH] D124669: [flang][driver] Add support for -save-temps

rovka added inline comments. Comment at: flang/test/Driver/fno-integrated-as.f90:6 +!-- +! Verify that there _is_ a seperate line with an assembler invocation +! RUN: %flang -c -fno-integrated-as %s -### 2>&1 | FileCheck %s

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 426747. awarzynski added a comment. Fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 Files: clang/include/clang/Driver/Options.td

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 426739. awarzynski added a comment. Add a test, restore white-space in Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 Files:

[PATCH] D124669: [flang][driver] Add support for -save-temps

rovka added a comment. I think I confused myself yesterday, it does make sense to add -fno-integrated-as for this. Could we add a test for it independent of save-temps? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/

[PATCH] D124669: [flang][driver] Add support for -save-temps

unterumarmung added inline comments. Comment at: clang/include/clang/Driver/Options.td:4131 def : Flag<["-"], "no-integrated-as">, Alias, - Flags<[CC1Option, NoXarchOption]>; + Flags<[CC1Option,FlangOption,NoXarchOption]>; rovka wrote: > awarzynski

[PATCH] D124669: [flang][driver] Add support for -save-temps

rovka added inline comments. Comment at: clang/include/clang/Driver/Options.td:4131 def : Flag<["-"], "no-integrated-as">, Alias, - Flags<[CC1Option, NoXarchOption]>; + Flags<[CC1Option,FlangOption,NoXarchOption]>; awarzynski wrote: > unterumarmung

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:3989 Group; -def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option, NoXarchOption]>, +def save_temps_EQ : Joined<["-", "--"], "save-temps=">,

[PATCH] D124669: [flang][driver] Add support for -save-temps

unterumarmung added inline comments. Comment at: clang/include/clang/Driver/Options.td:4131 def : Flag<["-"], "no-integrated-as">, Alias, - Flags<[CC1Option, NoXarchOption]>; + Flags<[CC1Option,FlangOption,NoXarchOption]>; Why not to add `FC1Option`

[PATCH] D124669: [flang][driver] Add support for -save-temps

schweitz added inline comments. Comment at: clang/include/clang/Driver/Options.td:3989 Group; -def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[CC1Option, NoXarchOption]>, +def save_temps_EQ : Joined<["-", "--"], "save-temps=">,

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, Leporacanthicus, unterumarmung, ekieri, schweitz, jeanPerier, peixin, shraiysh. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added