Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-09-09 Thread Dave Lee via cfe-commits
kastiglione added a comment. Thank you @klimek. http://reviews.llvm.org/D12471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-09-08 Thread Manuel Klimek via cfe-commits
klimek closed this revision. klimek added a comment. Committed as r246998. http://reviews.llvm.org/D12471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-09-08 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. This revision is now accepted and ready to land. LG, as this is a documentation change that looks about right, and comes with tests, and the original author doesn't jump in. http://reviews.llvm.org/D12471

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-09-03 Thread Dave Lee via cfe-commits
kastiglione added a comment. Thanks @klimek! There's certainly no rush on a diff like this :P http://reviews.llvm.org/D12471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-09-03 Thread Manuel Klimek via cfe-commits
klimek added a reviewer: dfsuther. klimek added a comment. +Dean, as I really don't know Obj-C (sorry for the delay in reply, was on vacation) http://reviews.llvm.org/D12471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-08-31 Thread Dave Lee via cfe-commits
kastiglione updated this revision to Diff 33665. kastiglione added a comment. Add test case for numSelectorArgs(0) http://reviews.llvm.org/D12471 Files: include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersTest.cpp Index: unittests/ASTMatchers/ASTMatchersTest.cpp ==

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-08-31 Thread Dave Lee via cfe-commits
kastiglione marked 2 inline comments as done. kastiglione added a comment. http://reviews.llvm.org/D12471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-08-31 Thread Dave Lee via cfe-commits
kastiglione added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:2140-2153 @@ -2139,16 +2139,16 @@ /// \brief Matches when the selector has the specified number of arguments /// -/// matcher = objCMessageExpr(numSelectorArgs(1)); +/// matcher = objCMess

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-08-30 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:2140-2153 @@ -2139,16 +2139,16 @@ /// \brief Matches when the selector has the specified number of arguments /// -/// matcher = objCMessageExpr(numSelectorArgs(1)); +/// matcher = objCMessageEx

[PATCH] D12471: Correct documentation for numSelectorArgs matcher

2015-08-29 Thread Dave Lee via cfe-commits
kastiglione created this revision. kastiglione added a reviewer: modocache. kastiglione added a subscriber: cfe-commits. Herald added a subscriber: klimek. Currently, the documentation for `numSelectorArgs` includes an incorrect example. It shows a case where an argument of 1 will match a propert