[PATCH] D124790: [HLSL] Enable half type for hlsl.

This revision was automatically updated to reflect the committed changes. Closed by commit rG77f72ac15bca: [HLSL] Enable half type for hlsl. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added a comment. Thanks for the review. Updated the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 ___ cfe-commits mailing list

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 439463. python3kgae marked 3 inline comments as done. python3kgae added a comment. Cleanup comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 Files:

[PATCH] D124790: [HLSL] Enable half type for hlsl.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor changes. Comment at: clang/lib/AST/ASTContext.cpp:1712 + case BuiltinType::Half: +// For HLSL, when not enable native half

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 438220. python3kgae added a comment. Change CXXABI to Microsoft to match dxc behavior. The mangle name for half is "$f16@" when half is treat as native half type and "$halff@" when treat as float. And now in AST, half is still half. Only in clang

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; aaron.ballman wrote: > beanz wrote: >

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 428153. python3kgae added a comment. Add Sema test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 Files: clang/include/clang/Driver/Options.td

[PATCH] D124790: [HLSL] Enable half type for hlsl.

aaron.ballman added a comment. This change should likely also have some Sema tests demonstrating what happens during constant expression evaluation, or narrowing conversions, etc given that the type may have different behavior. Comment at: clang/lib/Basic/LangOptions.cpp:197

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 427711. python3kgae added a comment. Rebase for fcgl change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/ https://reviews.llvm.org/D124790 Files: clang/include/clang/Driver/Options.td

[PATCH] D124790: [HLSL] Enable half type for hlsl.

beanz added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; aaron.ballman wrote: > python3kgae wrote: >

[PATCH] D124790: [HLSL] Enable half type for hlsl.

aaron.ballman added a comment. In D124790#3489690 , @python3kgae wrote: > Add option -fcgl which output clang codeGen result to avoid test dependent on > build DirectX backend. Thanks -- I think this should actually be a separate patch though, because

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; python3kgae wrote: > aaron.ballman

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 426854. python3kgae added a comment. Add option -fcgl which output clang codeGen result to avoid test dependent on build DirectX backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124790/new/

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL;

[PATCH] D124790: [HLSL] Enable half type for hlsl.

aaron.ballman added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL; python3kgae wrote: > aaron.ballman

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:197 - // OpenCL has half keyword - Opts.Half = Opts.OpenCL; + // OpenCL and HLSL have half keyword + Opts.Half = Opts.OpenCL || Opts.HLSL;

[PATCH] D124790: [HLSL] Enable half type for hlsl.

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Options.td:6766-6767 +def enable_16bit_types : DXCFlag<"enable-16bit-types">, Alias, + HelpText<"Enable 16bit types and disable min precision types." + "Available in HLSL 2018 and shader

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae created this revision. python3kgae added reviewers: Anastasia, aaron.ballman, beanz, pow2clk. Herald added a subscriber: dexonsmith. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: