[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rGee51e9795a31: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory (authored by rmaz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124946/new/

[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

urnathan accepted this revision. urnathan added a comment. This revision is now accepted and ready to land. good to go, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124946/new/ https://reviews.llvm.org/D124946

[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

rmaz added a comment. In D124946#3500454 , @urnathan wrote: > Looks good to me, but perhaps leave it a few days for others to comment (my > familiarity with this code is low). I do know people want relocatable > outputs though. Are we good to go with

[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

urnathan added a comment. Looks good to me, but perhaps leave it a few days for others to comment (my familiarity with this code is low). I do know people want relocatable outputs though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124946/new/

[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

rmaz updated this revision to Diff 427731. rmaz added a comment. fix for missing temp dir in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124946/new/ https://reviews.llvm.org/D124946 Files: clang/lib/Serialization/ASTReader.cpp

[PATCH] D124946: [clang] serialize ORIGINAL_PCH_DIR relative to BaseDirectory

rmaz created this revision. Herald added a project: All. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff changes the serialization of the `ORIGINAL_PCH_DIR` entry in module files to be serialized relative to the module's