[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

2022-05-04 Thread Zixu Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb5bb28511f2: Revert "Revert "[clang][extract-api] Use relative includes"" (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

2022-05-04 Thread Zixu Wang via Phabricator via cfe-commits
zixuw added a comment. In D124964#3492423 , @dang wrote: > LGTM! If I understand the issue correctly we gave `llvm::Regex::match` a > string temporary to match against before and now we store it for long enough > to process the match results? Yup, exac

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

2022-05-04 Thread Daniel Grumberg via Phabricator via cfe-commits
dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! If I understand the issue correctly we gave `llvm::Regex::match` a string temporary to match against before and now we store it for long enough to process the match results? Repository:

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

2022-05-04 Thread Zixu Wang via Phabricator via cfe-commits
zixuw updated this revision to Diff 427140. zixuw added a comment. Whitespace change: clang-format removed an empty line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124964/new/ https://reviews.llvm.org/D124964 Files: clang/include/clang/Extrac

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

2022-05-04 Thread Zixu Wang via Phabricator via cfe-commits
zixuw created this revision. zixuw added reviewers: ributzka, dang, cishida. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reapply the change after fixing sanitizer errors. The original problem was that