[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e2709479636: [clang] Include clang config.h in LangStandards.cpp (authored by porglezomp). Changed prior to commit: https://reviews.llvm.org/D124974?vs=429275=429416#toc Repository: rG LLVM Github

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

dexonsmith accepted this revision. dexonsmith added a comment. LGTM, thanks! One comment online below. Comment at: clang/include/clang/Config/config.h.cmake:19 #cmakedefine CLANG_DEFAULT_STD_C LangStandard::lang_${CLANG_DEFAULT_STD_C} +// Always #define something so that

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp updated this revision to Diff 429275. porglezomp added a comment. I haven't used arc in a little while and am having trouble sorry for the emails Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp updated this revision to Diff 429274. porglezomp added a comment. Arcanist accidentally threw away the first commit in the sequence... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974 Files:

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp updated this revision to Diff 429273. porglezomp added a comment. Herald added a subscriber: mgorny. Add changes suggested by Duncan to make CLANG_DEFAULT_STD_C more misuse-resistant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp added a comment. That looks good to me. I'm testing it out locally to make sure it still works right and also catches the issue, and will plan put up an updated patch in the morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

dexonsmith added a comment. In D124974#3504986 , @porglezomp wrote: > Ah, so it'd be a test that passes pretty trivially on any bot that doesn't > have a custom version of `CLANG_DEFAULT_STD_C` and `CLANG_DEFAULT_STD_CXX` > like the default config,

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp added a comment. Ah, so it'd be a test that passes pretty trivially on any bot that doesn't have a custom version of `CLANG_DEFAULT_STD_C` and `CLANG_DEFAULT_STD_CXX` like the default config, but could get caught by any other bots that do set it? What's the best way to get the

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

dexonsmith added a comment. In D124974#3494374 , @sammccall wrote: > In D124974#3494279 , @dexonsmith > wrote: > >> Can we add a test for this? > > I think the problem with testing it is that this variable comes

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp added a comment. Unless anyone has an idea about how to test this, I'm going to commit this without adding a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

sammccall added a comment. In D124974#3494279 , @dexonsmith wrote: > Can we add a test for this? I think the problem with testing it is that this variable comes from the CMake config, and in the default configuration (as used by all the bots) it's not

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

dexonsmith added a comment. Can we add a test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp created this revision. porglezomp added reviewers: hokein, sammccall, dexonsmith. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary in order to pick up the default C/C++