[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

This revision was automatically updated to reflect the committed changes. Closed by commit rGe57f57841fbb: [clang-format] fix alignment w/o binpacked args (authored by cha5on, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

cha5on added a comment. In D125162#3510737 , @curdeius wrote: > LGTM. Tell us if you need help landing this. I don't have commit access, so some help would be great :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Tell us if you need help landing this. Thanks a lot for your contribution! Comment at: clang/lib/Format/WhitespaceManager.cpp:374-375 return false; +

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

cha5on added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:374-375 return false; + if (Changes[i].Tok->is(tok::l_brace) && + Changes[i].Tok->is(BK_BracedInit)) +return true; curdeius wrote: >

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

cha5on updated this revision to Diff 429138. cha5on marked 4 inline comments as done. cha5on added a comment. Update for review. - Further simplify testcases. - Update issue URL in comment to use llvm.org alias. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17286 + // BinPackArguments. + // See https://github.com/llvm/llvm-project/issues/55360 + Alignment = getLLVMStyleWithColumns(50); I'd drop that, or at least replace

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

curdeius added a comment. Thanks for creating the bug report. A few more comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:374-375 return false; + if (Changes[i].Tok->is(tok::l_brace) && + Changes[i].Tok->is(BK_BracedInit)) +

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

cha5on marked 3 inline comments as done. cha5on added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17321 + +verifyFormat(Expected, ToFormat, Alignment); + } curdeius wrote: > I don't think you need to create variables, just online the

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

cha5on updated this revision to Diff 428262. cha5on added a comment. Update for review - Add and link bug report. - Remove braces per LLVM style. - Shrink down test case and add second case for direct-list-initialization alignment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

curdeius added a comment. FYI, I like to have a bug report because people that encounter the same problem (in an older release) can find it easily, and see if/when it was fixed. It also avoid working on the same thing by different people. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Thanks for working on this! Is there a bug report somewhere? If not, may you create one please? Comment at: clang/lib/Format/WhitespaceManager.cpp:398 +

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

HazardyKnusperkeks added a comment. For me there needs no bug report, but could you comment on the misformatting without the patch? Comment at: clang/unittests/Format/FormatTest.cpp:17289 + Alignment.BinPackArguments = false; + { +const char *Expected = "struct A {\n"

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

cha5on created this revision. Herald added a project: All. cha5on requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The combination of - AlignConsecutiveAssignments.Enabled = true - BinPackArguments = false would result in the first