[PATCH] D125396: [clang] Fix KEYALL

2022-05-11 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG84db35594953: [clang] Fix KEYALL (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D125396: [clang] Fix KEYALL

2022-05-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D125396#3506478 , @delcypher wrote: > @yaxunl Thanks for addressing my feedback so quickly. I think the commit > message should also mention that `KEYCUDA` is now included in `KEYALL`. Other > than that LGTM. will do when com

[PATCH] D125396: [clang] Fix KEYALL

2022-05-11 Thread Dan Liew via Phabricator via cfe-commits
delcypher accepted this revision. delcypher added a comment. This revision is now accepted and ready to land. @yaxunl Thanks for addressing my feedback so quickly. I think the commit message should also mention that `KEYCUDA` is now included in `KEYALL`. Other than that LGTM. CHANGES SINCE LAS

[PATCH] D125396: [clang] Fix KEYALL

2022-05-11 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: delcypher, aaron.ballman, tra, rsmith. Herald added a project: All. yaxunl requested review of this revision. Introduce KEYMAX and a generic way to update KEYALL. https://reviews.llvm.org/D125396 Files: clang/lib/Basic/IdentifierTable.cpp