[PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-01 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added reviewers: jyknight, chandlerc. dougk added a subscriber: cfe-commits. Herald added a subscriber: jyknight. Rename SHAVE toolchain to Myriad toolchain. Run the Myriad linker whenever the vendor [sic] is Myriad. Also recognize RTEMS as the OS, and do someth

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-14 Thread Douglas Katzman via cfe-commits
dougk updated the summary for this revision. dougk updated this revision to Diff 34682. dougk added a comment. Changes per review - but only a minimally correct change to finding the libraries. Using multilibs remains as a future task. Also renamed SHAVE::Linker to Myriad::Linker. http://review

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-14 Thread Douglas Katzman via cfe-commits
dougk updated this revision to Diff 34729. dougk added a comment. Delete the overrides of getTool() and buildAssembler() in MyriadToolChain. http://reviews.llvm.org/D12541 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/To

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-14 Thread James Y Knight via cfe-commits
jyknight added inline comments. Comment at: lib/Driver/ToolChains.cpp:3929 @@ +3928,3 @@ +: Generic_GCC(D, Triple, Args) { + // If a target of 'sparc-myriad-elf' is specified to clang, it wants to use + // 'sparc-myriad--elf' (note the unknown OS) as the canonical triple. --

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-17 Thread Douglas Katzman via cfe-commits
dougk updated this revision to Diff 34998. dougk marked 3 inline comments as done. dougk added a comment. Use the same logic as Solaris::Solaris to die in the toolchain constructor if getArch() is unexpected. Also don't hardcode -EL in linker. http://reviews.llvm.org/D12541 Files: lib/Driver

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-17 Thread James Y Knight via cfe-commits
jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. Other than minor comments, lgtm. Comment at: lib/Driver/ToolChains.cpp:3937 @@ +3936,3 @@ + default: +llvm_unreachable("Unsupported architecture"); + case llvm::Trip

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-17 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. dougk marked 2 inline comments as done. Closed by commit rL247924: [Shave]: Drive sparc-myriad-elf-ld directly rather than via gcc. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D12541?vs=34998&id=

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-01 Thread Douglas Katzman via cfe-commits
dougk updated the summary for this revision. dougk updated this revision to Diff 33778. dougk added a comment. Revised tests. http://reviews.llvm.org/D12541 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h test/Dr

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-02 Thread James Y Knight via cfe-commits
jyknight added inline comments. Comment at: lib/Driver/ToolChains.cpp:3936 @@ -3914,9 +3935,3 @@ -SHAVEToolChain::SHAVEToolChain(const Driver &D, const llvm::Triple &Triple, - const ArgList &Args) -: Generic_GCC(D, Triple, Args) {} - -SHAVEToolC